On Thu, Mar 12, 2015 at 2:00 AM, Laurent Pinchart
[off-list ref] wrote:

quoted

@@ -322,13 +319,15 @@ int sh_pfc_config_mux(struct sh_pfc *pfc, unsigned

mark, int pinmux_type) return -EINVAL;
      }

-     pos = 0;
-     enum_id = 0;
-     field = 0;
-     value = 0;
-
      /* Iterate over all the configuration fields we need to update. */
      while (1) {
+             const struct pinmux_cfg_reg *cr = NULL;
+             unsigned int field = 0;
+             u16 enum_id = 0;
+             u32 value = 0;

There's no need to initialize field, enum_id and value to 0 here.

And cr.

With that fixed,

Will update and resend.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds