Thread (11 messages) 11 messages, 4 authors, 2015-06-03

Re: [PATCH] sh-pfc: handle pin array holes in sh_pfc_map_pins()

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2015-03-06 13:17:36
Also in: linux-sh

Hi Sergei,

On Friday 06 March 2015 15:42:05 Sergei Shtylyov wrote:
On 3/6/2015 1:43 PM, Linus Walleij wrote:
quoted
quoted
The  pin array handled by sh_pfc_map_pins() may contain holes
representing non- existing pins. We have to first count the valid pins
in order to calculate the size  of the memory to be allocated, then to
skip over the non-existing pins when  initializing the allocated arrays,
and then to return the number of valid pins  from sh_pfc_map_pins()
instead of 0 on success.

As we have to touch devm_kzalloc() calls anyway, use more fitting
devm_kcalloc() instead which additionally checks the array size. And
since PINMUX_TYPE_NONE is #define'd as 0, stop re-initializing already
zeroed out 'pmx->configs' array.

Signed-off-by: Sergei Shtylyov <redacted>

---
The patch is against the 'devel' branch of Linus W.'s 'linux-pinctrl.git'
repo. This patch should be applied before my R8A7794 PFC support patch
and before Laurent's patches removing non-existent GPIOs for R8A779[01],
otherwise they would cause the kernel  to hang while booting!
OK not applying this until ACKed by Laurent,
and in the meantime I'm taking the three applied R8A7794 patches
out of my tree again.
Thanks!
quoted
Can you please send these depending patches as a series with this
patch as 1/4 and the three R8A7794 patches as 2,3,4/4? Thanks.
OK, will try to remember. But what about Lauren't 2 patches also
dependent on this one?
If you don't mind, please also include them in your series.

-- 
Regards,

Laurent Pinchart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help