Thread (24 messages) 24 messages, 4 authors, 2015-03-09

Re: [PATCH 2/4] pinctrl: sh-pfc: Store register/field widths in u8 instead of unsigned long

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2015-03-06 11:34:59
Also in: linux-sh

Hi Geert,

On Friday 06 March 2015 12:26:57 Geert Uytterhoeven wrote:
On Fri, Mar 6, 2015 at 11:48 AM, Linus Walleij wrote:
quoted
On Fri, Feb 27, 2015 at 6:38 PM, Geert Uytterhoeven wrote:
quoted
Register and field widths are in the range 1..32. Storing them in the
pinctrl data in (arrays of) unsigned long wastes space.

This decreases the size of a (32-bit) shmobile_defconfig kernel
supporting 7 SoCs by 26460 bytes.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
This 2/4 is not ACKed so pausing application after 1/4.

Is 3,4/4 independent of this patch?
Unfortunately not, as there are contextual dependencies.

Laurent: Is 2/4 OK for you as-is? Your comments about the size of reg are
not related to "Store register/field widths in u8 instead of unsigned long",
and thus an area for future improvement.
As just stated in a different reply to this patch, if you change reg to a u32 
in a separate patch (maybe as a v2 of 3/4 ?),

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

for this patch.

-- 
Regards,

Laurent Pinchart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help