Re: [PATCH 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations
From: Aaro Koskinen <aaro.koskinen@iki.fi>
Date: 2015-03-22 17:33:05
Also in:
linux-omap, lkml
Hi, On Fri, Mar 20, 2015 at 05:11:23PM +0200, Grygorii.Strashko@linaro.org wrote:
On 03/20/2015 01:00 AM, Tony Lindgren wrote:quoted
* grygorii.strashko@linaro.org [off-list ref] [150319 10:26]:quoted
From: Grygorii Strashko <redacted> Now in TI OMAP GPIO driver there are a lot of places where System GPIO number calculated and then converted to GPIO offset. What is worse is that in many place such conversation performed twice or even three times. But actually, we don't need to do that at all, because - gpiolib always passes GPIO offset to GPIO controller - OMAP GPIO driver converted to use IRQ domain, so struct irq_data->hwirq contains GPIO offset Hence, it is safe to convert all GPIO OMAP functions to use GPIO offset instead of system GPIO numbers. Also, this allows to remove unneeded conversations routines #define GPIO_INDEX(bank, gpio) #define GPIO_BIT(bank, gpio) int omap_irq_to_gpio()Right on! This is excellent news. I've tested this set on top of -rc4 plus the patch mentioned below, and I'm not seeing regressions on the platforms I tested with. Wake up to smsc911x ping with off-idle still works on omap3. I only briefly tested on omap1 (osk5912), so I'like to wait for Aaro's ack before this gets merged. I found one build error, other than that, for the whole series please feel free to add: Tested-by: Tony Lindgren <tony@atomide.com>Thanks Tony. Yep. I'll wait for news from Aaro then will re-send if ok.
Works fine on 770 and E3. Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi> A.