Thread (5 messages) 5 messages, 3 authors, 2015-01-27

[PATCH] usb: phy-generic: Don't fail on missing gpio reset

From: Soren Brinkmann <hidden>
Date: 2015-01-27 01:45:44
Also in: linux-arm-kernel, linux-devicetree, lkml
Subsystem: the rest, usb subsystem · Maintainers: Linus Torvalds, Greg Kroah-Hartman

A reset through a GPIO is optional. Don't fail probing when it is
missing.

Reported-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Soren Brinkmann <redacted>
---
Hi Andreas,

does this do the trick?

	Thanks,
	Sören

 drivers/usb/phy/phy-generic.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
index dd05254241fb..a73d4c738f0b 100644
--- a/drivers/usb/phy/phy-generic.c
+++ b/drivers/usb/phy/phy-generic.c
@@ -241,10 +241,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop,
 
 	if (err == -EPROBE_DEFER)
 		return -EPROBE_DEFER;
-	if (err) {
-		dev_err(dev, "Error requesting RESET GPIO\n");
-		return err;
-	}
+	if (err)
+		nop->gpiod_reset = NULL;
 
 	nop->phy.otg = devm_kzalloc(dev, sizeof(*nop->phy.otg),
 			GFP_KERNEL);
-- 
2.2.2.1.g63c5777
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help