Re: [PATCH v5 6/7] gpio/gpiolib-of: Create of_mm_gpiochip_remove
From: Linus Walleij <hidden>
Date: 2015-01-12 09:30:16
Also in:
lkml
On Wed, Dec 17, 2014 at 4:51 PM, Ricardo Ribalda Delgado [off-list ref] wrote:
Create counterpart of of_mm_gpiochip_add(). This way the modules that can be removable do not duplicate the cleanup code. Suggested-by: Alexandre Courbot <redacted> Signed-off-by: Ricardo Ribalda Delgado <redacted>
Patch applied. Hm. $ git grep of_mm_gpiochip_add arch/powerpc/sysdev/cpm1.c: return of_mm_gpiochip_add(np, mm_gc); arch/powerpc/sysdev/cpm1.c: return of_mm_gpiochip_add(np, mm_gc); arch/powerpc/sysdev/cpm_common.c: return of_mm_gpiochip_add(np, mm_gc); arch/powerpc/sysdev/ppc4xx_gpio.c: ret = of_mm_gpiochip_add(np, mm_gc); arch/powerpc/sysdev/qe_lib/gpio.c: ret = of_mm_gpiochip_add(np, mm_gc); arch/powerpc/sysdev/simple_gpio.c: ret = of_mm_gpiochip_add(np, mm_gc); drivers/gpio/gpio-ge.c: return of_mm_gpiochip_add(pdev->dev.of_node, mmchip); drivers/gpio/gpio-mm-lantiq.c: ret = of_mm_gpiochip_add(pdev->dev.of_node, &chip->mmchip); drivers/gpio/gpio-mpc5200.c: ret = of_mm_gpiochip_add(ofdev->dev.of_node, &chip->mmchip); drivers/gpio/gpio-mpc5200.c: ret = of_mm_gpiochip_add(ofdev->dev.of_node, &chip->mmchip); drivers/gpio/gpio-mpc8xxx.c: ret = of_mm_gpiochip_add(np, mm_gc); drivers/gpio/gpio-xilinx.c: status = of_mm_gpiochip_add(np, &chip->mmchip); drivers/gpio/gpio-zevio.c: status = of_mm_gpiochip_add(pdev->dev.of_node, &(controller->chip)); Should these all be patched to use this, or reviewed for applicability? Yours, Linus Walleij