On Thu, 09 Oct 2014, Johan Hovold wrote:

On Thu, Oct 09, 2014 at 08:40:29AM +0100, Lee Jones wrote:

quoted

On Mon, 06 Oct 2014, Muthu Mani wrote:

quoted

quoted

+static int update_ep_details(struct usb_interface *interface,
+				struct cyusbs23x *cyusbs)
+{
+	struct usb_host_interface *iface_desc;
+	struct usb_endpoint_descriptor *ep;
+	int i;
+
+	iface_desc = interface->cur_altsetting;
+
+	for (i = 0; i < iface_desc->desc.bNumEndpoints; ++i) {
+
+		ep = &iface_desc->endpoint[i].desc;
+
+		if (!cyusbs->bulk_in_ep_num && usb_endpoint_is_bulk_in(ep))
+			cyusbs->bulk_in_ep_num = ep->bEndpointAddress;
+		if (!cyusbs->bulk_out_ep_num && usb_endpoint_is_bulk_out(ep))
+			cyusbs->bulk_out_ep_num = ep->bEndpointAddress;
+		if (!cyusbs->intr_in_ep_num && usb_endpoint_is_int_in(ep))
+			cyusbs->intr_in_ep_num = ep->bEndpointAddress;
+	}

All of the USB specific code in this driver will require a USB Ack.

I'll review it once the incomplete gpio-driver issue has been resolved.

Okay, great.

quoted

quoted

+	dev_dbg(&interface->dev, "%s intr_in=%d, bulk_in=%d, bulk_out=%d\n",
+		__func__, cyusbs->intr_in_ep_num ,
+		cyusbs->bulk_in_ep_num, cyusbs->bulk_out_ep_num);
+
+	if (!cyusbs->bulk_in_ep_num || !cyusbs->bulk_out_ep_num ||
+		!cyusbs->intr_in_ep_num)
+		return -ENODEV;
+
+	return 0;
+}

[...]

quoted

quoted

diff --git a/include/linux/mfd/cyusbs23x.h b/include/linux/mfd/cyusbs23x.h

quoted

quoted

+/* Serial interfaces (I2C, SPI, UART) differ in interface subclass */
+enum cy_scb_modes {
+	CY_USBS_SCB_DISABLED = 0,
+	CY_USBS_SCB_UART = 1,
+	CY_USBS_SCB_SPI = 2,
+	CY_USBS_SCB_I2C = 3

No need to number these.

As it's not an arbitrary enumeration, I think they should be initialised
explicitly.

No need.  You are protected by the C Standard:

6.7.2.2 Enumeration specifiers

"If the first enumerator has no =, the value of its enumeration
constant is 0. Each subsequent enumerator with no = defines its
enumeration constant as the value of the constant expression obtained
by adding 1 to the value of the previous enumeration constant."

There's nothing arbitrary about that.

They could be defined in the mfd driver though, as they only
appear to be needed during probe.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html