[PATCH] drivers/gpio/gpio-sch311x: check return value of gpiochip_remove()
From: Varka Bhadram <hidden>
Date: 2014-07-04 06:38:54
Also in:
lkml
Subsystem:
gpio subsystem, the rest · Maintainers:
Linus Walleij, Bartosz Golaszewski, Linus Torvalds
This patch eliminates the following warning drivers/gpio/gpio-sch311x.c: In function ‘sch311x_gpio_probe’: drivers/gpio/gpio-sch311x.c:286:18: warning: ignoring return value of ‘gpiochip_remove’, declared with attribute warn_unused_result Signed-off-by: Varka Bhadram <redacted> --- drivers/gpio/gpio-sch311x.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-sch311x.c b/drivers/gpio/gpio-sch311x.c
index f942b80..8a4ab8f 100644
--- a/drivers/gpio/gpio-sch311x.c
+++ b/drivers/gpio/gpio-sch311x.c@@ -232,7 +232,7 @@ static int sch311x_gpio_probe(struct platform_device *pdev) struct sch311x_pdev_data *pdata = pdev->dev.platform_data; struct sch311x_gpio_priv *priv; struct sch311x_gpio_block *block; - int err, i; + int err, i, ret; /* we can register all GPIO data registers at once */ if (!request_region(pdata->runtime_reg + GP1, 6, DRV_NAME)) {
@@ -283,7 +283,11 @@ exit_err: release_region(pdata->runtime_reg + GP1, 6); /* release already registered chips */ for (--i; i >= 0; i--) - gpiochip_remove(&priv->blocks[i].chip); + ret = gpiochip_remove(&priv->blocks[i].chip); + + WARN(ret, "%s(): gpiochip_remove() failed, ret=%d\n", + __func__, ret); + return err; }
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html