Thread (5 messages) 5 messages, 4 authors, 2014-03-14

Re: [PATCH] gpio: mcp23s08: Trivial: Fixed coding style issues

From: Gerhard Sittig <hidden>
Date: 2014-03-12 20:16:32
Also in: lkml

On Wed, Mar 12, 2014 at 14:53 +0100, Linus Walleij wrote:
On Fri, Mar 7, 2014 at 12:25 AM, Gary Servin [off-list ref] wrote:
quoted
This coding style issue was detected using the checkpatch.pl script

Signed-off-by: Gary Servin <redacted>
Sometimes the compiler is just too forgiving :-/
Thanks a lot for fixing this, patch applied.
I think the code had no syntax or language issue before.  The
cleanup really was about style exclusively (which still is a good
thing).  'sizeof' is an operator, very much like a unary minus or
unary ampersand which neither require parentheses.  So either of
"sizeof(x)" as well as "sizeof x" are legal with regard to the C
language.  It's just that the community prefers "sizeof(x)" for
the improved readability.


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help