Re: [PATCH] gpio: pca953x: fix gpio input on gpio offsets >= 8
From: Linus Walleij <hidden>
Date: 2013-08-16 15:19:58
Possibly related (same subject, not in this thread)
- 2013-08-14 · Re: [PATCH] gpio: pca953x: fix gpio input on gpio offsets >= 8 · Andrew Ruder <hidden>
- 2013-08-12 · Re: [PATCH] gpio: pca953x: fix gpio input on gpio offsets >= 8 · Gregory CLEMENT <hidden>
On Wed, Aug 7, 2013 at 11:52 PM, Andrew Ruder [off-list ref] wrote:
This change fixes a regression introduced by commit f5f0b7aa8 (gpio: pca953x: make the register access by GPIO bank) When the pca953x driver was converted to using 8-bit reads/writes the bitmask in pca953x_gpio_get_value wasn't adjusted with a modulus BANK_SZ and consequently looks at the wrong bits in the input register. Signed-off-by: Andrew Ruder <redacted>
Patch applied with Gregory's ACK. Yours, Linus Walleij