Re: [PATCH 1/5] drivers/gpio/gpio-omap.c: convert comma to semicolon
From: Linus Walleij <hidden>
Date: 2013-08-16 15:13:35
Also in:
kernel-janitors, linux-omap, lkml
Possibly related (same subject, not in this thread)
- 2013-08-10 · Re: [PATCH 1/5] drivers/gpio/gpio-omap.c: convert comma to semicolon · Joe Perches <joe@perches.com>
- 2013-08-10 · [PATCH 1/5] drivers/gpio/gpio-omap.c: convert comma to semicolon · Julia Lawall <hidden>
On Mon, Aug 12, 2013 at 6:15 PM, Kevin Hilman [off-list ref] wrote:
Joe Perches [off-list ref] writes:quoted
On Sat, 2013-08-10 at 17:40 +0200, Julia Lawall wrote:quoted
From: Julia Lawall <redacted> Replace a comma between expression statements by a semicolon.[]quoted
I can't tell if the assignment to ct->regs.mask is really intended to be under the if. The proposed patch preserves the current semantics, but not the current indentation.I'd suspect more that the indentation is correct and the comma use incorrect. It also looks more like a copy/paste error from commit f8b46b583 when the code was restructured a bit. Kevin?Yes, looks like a copy/paste error. The comma should simply be replaced by a semi-colon.
So can I have a patch for this? Pretty please... Yours, Linus Walleij