Thread (18 messages) 18 messages, 4 authors, 2021-11-29

Re: [PATCH v2 4/9] watchdog: move watchdog sysctl interface to watchdog.c

From: Petr Mladek <pmladek@suse.com>
Date: 2021-11-26 09:43:03
Also in: lkml

On Tue 2021-11-23 12:23:42, Luis Chamberlain wrote:
From: Xiaoming Ni <redacted>

The kernel/sysctl.c is a kitchen sink where everyone leaves
their dirty dishes, this makes it very difficult to maintain.

To help with this maintenance let's start by moving sysctls to
places where they actually belong. The proc sysctl maintainers
do not want to know what sysctl knobs you wish to add for your own
piece of code, we just care about the core logic of proc sysctl.

So, move the watchdog syscl interface to watchdog.c.
Use register_sysctl() to register the sysctl interface to avoid
merge conflicts when different features modify sysctl.c at the
same time.

Signed-off-by: Xiaoming Ni <redacted>
Reviewed-by: Kees Cook <redacted>
[mcgrof: justify the move on the commit log]
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help