Re: [PATCH 2/5] mm/vmscan: Throttle reclaim and compaction when too may... | linux-fsdevel

[RFC PATCH 0/5] Remove dependency on congestion_wait in mm/ · Mel Gorman <hidden> · 2021-09-20
[PATCH 4/5] mm/writeback: Throttle based on page writeback instead of congestion · Mel Gorman <hidden> · 2021-09-20
[PATCH 5/5] mm/page_alloc: Remove the throttling logic from the page allocator · Mel Gorman <hidden> · 2021-09-20
[PATCH 2/5] mm/vmscan: Throttle reclaim and compaction when too may pages are isolated · Mel Gorman <hidden> · 2021-09-20
Re: [PATCH 2/5] mm/vmscan: Throttle reclaim and compaction when too may pages are isolated · NeilBrown <hidden> · 2021-09-20
Re: [PATCH 2/5] mm/vmscan: Throttle reclaim and compaction when too may pages are isolated · Mel Gorman <hidden> · 2021-09-21
Re: [PATCH 2/5] mm/vmscan: Throttle reclaim and compaction when too may pages are isolated · Yang Shi <hidden> · 2021-09-21
Re: [PATCH 2/5] mm/vmscan: Throttle reclaim and compaction when too may pages are isolated · Mel Gorman <hidden> · 2021-09-22
[PATCH 1/5] mm/vmscan: Throttle reclaim until some writeback completes if congested · Mel Gorman <hidden> · 2021-09-20
Re: [PATCH 1/5] mm/vmscan: Throttle reclaim until some writeback completes if congested · NeilBrown <hidden> · 2021-09-20
Re: [PATCH 1/5] mm/vmscan: Throttle reclaim until some writeback completes if congested · Mel Gorman <hidden> · 2021-09-21
Re: [PATCH 1/5] mm/vmscan: Throttle reclaim until some writeback completes if congested · NeilBrown <hidden> · 2021-09-21
Re: [PATCH 1/5] mm/vmscan: Throttle reclaim until some writeback completes if congested · NeilBrown <hidden> · 2021-09-21
Re: [PATCH 1/5] mm/vmscan: Throttle reclaim until some writeback completes if congested · Mel Gorman <hidden> · 2021-09-21
Re: [PATCH 1/5] mm/vmscan: Throttle reclaim until some writeback completes if congested · NeilBrown <hidden> · 2021-09-21
Re: [PATCH 1/5] mm/vmscan: Throttle reclaim until some writeback completes if congested · Dave Chinner <david@fromorbit.com> · 2021-09-22
Re: [PATCH 1/5] mm/vmscan: Throttle reclaim until some writeback completes if congested · Mel Gorman <hidden> · 2021-09-22
[PATCH 3/5] mm/vmscan: Throttle reclaim when no progress is being made · Mel Gorman <hidden> · 2021-09-20
Re: [PATCH 3/5] mm/vmscan: Throttle reclaim when no progress is being made · NeilBrown <hidden> · 2021-09-20
Re: [PATCH 3/5] mm/vmscan: Throttle reclaim when no progress is being made · Mel Gorman <hidden> · 2021-09-21
Re: [PATCH 3/5] mm/vmscan: Throttle reclaim when no progress is being made · NeilBrown <hidden> · 2021-09-21
Re: [PATCH 3/5] mm/vmscan: Throttle reclaim when no progress is being made · Mel Gorman <hidden> · 2021-09-22
Re: [RFC PATCH 0/5] Remove dependency on congestion_wait in mm/ · Matthew Wilcox <willy@infradead.org> · 2021-09-20
Re: [RFC PATCH 0/5] Remove dependency on congestion_wait in mm/ · Mel Gorman <hidden> · 2021-09-20
Re: [RFC PATCH 0/5] Remove dependency on congestion_wait in mm/ · David Sterba <hidden> · 2021-09-20
Re: [RFC PATCH 0/5] Remove dependency on congestion_wait in mm/ · Mel Gorman <hidden> · 2021-09-21
Re: [RFC PATCH 0/5] Remove dependency on congestion_wait in mm/ · Mel Gorman <hidden> · 2021-09-20
Re: [RFC PATCH 0/5] Remove dependency on congestion_wait in mm/ · Dave Chinner <david@fromorbit.com> · 2021-09-21
Re: [RFC PATCH 0/5] Remove dependency on congestion_wait in mm/ · Mel Gorman <hidden> · 2021-09-22

Re: [PATCH 2/5] mm/vmscan: Throttle reclaim and compaction when too may pages are isolated

From: NeilBrown <hidden>
Date: 2021-09-20 23:30:07
Also in: linux-mm, lkml

On Mon, 20 Sep 2021, Mel Gorman wrote:

quoted hunk ↗ jump to hunk

@@ -2291,8 +2302,7 @@ shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec,
 			return 0;
 
 		/* wait a bit for the reclaimer. */
-		msleep(100);
-		stalled = true;
+		reclaim_throttle(pgdat, VMSCAN_THROTTLE_ISOLATED, HZ/10);

Why drop the assignment to "stalled"?
Doing that changes the character of the loop - and makes the 'stalled'
variable always 'false'.

NeilBrown

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help