Re: [RFC PATCH 03/20] udf: Fix iocharset=utf8 mount option
From: Jan Kara <jack@suse.cz>
Date: 2021-08-13 13:48:27
Also in:
linux-cifs, lkml
From: Jan Kara <jack@suse.cz>
Date: 2021-08-13 13:48:27
Also in:
linux-cifs, lkml
On Thu 12-08-21 17:51:34, Pali Rohár wrote:
On Thursday 12 August 2021 16:17:36 Jan Kara wrote:quoted
On Sun 08-08-21 18:24:36, Pali Rohár wrote:quoted
Currently iocharset=utf8 mount option is broken. To use UTF-8 as iocharset, it is required to use utf8 mount option. Fix iocharset=utf8 mount option to use be equivalent to the utf8 mount option. If UTF-8 as iocharset is used then s_nls_map is set to NULL. So simplify code around, remove UDF_FLAG_NLS_MAP and UDF_FLAG_UTF8 flags as to distinguish between UTF-8 and non-UTF-8 it is needed just to check if s_nls_map set to NULL or not. Signed-off-by: Pali Rohár <pali@kernel.org>Thanks for the cleanup. It looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Or should I take this patch through my tree?Hello! Patches are just RFC, mostly untested and not ready for merging. I will wait for feedback and then I do more testing nad prepare new patch series.
OK, FWIW I've also tested the UDF and isofs patches. Honza -- Jan Kara [off-list ref] SUSE Labs, CR