Thread (389 messages) 389 messages, 13 authors, 2021-08-21

Re: [PATCH v14 062/138] mm/migrate: Add folio_migrate_copy()

From: Matthew Wilcox <willy@infradead.org>
Date: 2021-08-13 04:16:53
Also in: linux-mm, lkml

On Thu, Aug 12, 2021 at 01:56:24PM +0200, Vlastimil Babka wrote:
On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote:
quoted
This is the folio equivalent of migrate_page_copy(), which is retained
as a wrapper for filesystems which are not yet converted to folios.
Also convert copy_huge_page() to folio_copy().

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Vlastimil Babka <redacted>

The way folio_copy() avoids cond_resched() for single page would IMHO deserve a
comment though, so it's not buried only in this thread.
I think folio_copy() deserves kernel-doc.

/**
 * folio_copy - Copy the contents of one folio to another.
 * @dst: Folio to copy to.
 * @src: Folio to copy from.
 *
 * The bytes in the folio represented by @src are copied to @dst.
 * Assumes the caller has validated that @dst is at least as large as @src.
 * Can be called in atomic context for order-0 folios, but if the folio is
 * larger, it may sleep.
 */
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help