Thread (8 messages) 8 messages, 4 authors, 2021-08-03

Re: [PATCH v9] iomap: Support file tail packing

From: Gao Xiang <hidden>
Date: 2021-08-02 12:15:46
Also in: lkml

Hi Andreas,

On Sun, Aug 01, 2021 at 02:03:33PM +0200, Andreas Gruenbacher wrote:
On Tue, Jul 27, 2021 at 5:00 AM Gao Xiang [off-list ref] wrote:
...
quoted
+static int iomap_write_begin_inline(struct inode *inode,
+               struct page *page, struct iomap *srcmap)
+{
+       /* needs more work for the tailpacking case, disable for now */
Nit: the comma should be a semicolon or period here.
Sorry for some delay (busy in other things...)

Yeah, that's fine to me, in English contexts it'd be better like that
(there is some punctuation rule difference between languages.)


Hi Darrick,
Should I resend v10 for this punctuation change or could you kindly
help revise this?

(btw, would you mind set up a for-next iomap branch so I could rebase
 other EROFS patches on iomap for-next, thank you very much!)

Thanks,
Gao Xiang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help