Re: [bug report] fanotify: fix copy_event_to_user() fid error clean up

On Thu, Jul 22, 2021 at 05:01:03PM +0300, Dan Carpenter wrote:

On Thu, Jul 22, 2021 at 12:31:42PM +0300, Dan Carpenter wrote:

quoted

Smatch is *supposed* to know about the relationship between those two.
The bug is actually that Smatch records in the database that create_fd()
always fails.  It's a serious bug, and I'm trying to investigate what's
going on and I'm sure that I will fix this before the end of the week.

I'm testing a Smatch fix for this so hopefully it will pushed in a few
days.

Great!

Well, do let us know what the outcome is post running the Smatch tests
against the copy_event_to_user() function once again...

I do feel as though shuffling things around isn't necessary. Especially
considering the fact that what is current is correct and as you mentioned
this is a perfect oppurtunity to make the tooling better. :)

/M