Thread (18 messages) flat view 18 messages, 2 authors, 2021-07-08

Re: [PATCH v8 03/11] fs: make do_mkdirat() take struct filename

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2021-07-07 19:20:56
Also in: io-uring

On Wed, Jul 7, 2021 at 5:28 AM Dmitry Kadashev [off-list ref] wrote:
Pass in the struct filename pointers instead of the user string, and
update the three callers to do the same. This is heavily based on
commit dbea8d345177 ("fs: make do_renameat2() take struct filename").

This behaves like do_unlinkat() and do_renameat2().
.. and now I like this version too. And that do_mkdirat() could have
the same pattern with a "mkdirat_helper()" and avoiding the "goto
retry" and "goto out_putname" things, and be more understandable that
way.

Again, that could - and maybe should - be a separate cleanup.

             Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help