On Tue, 8 Jun 2021 17:51:03 +0200
Max Reitz [off-list ref] wrote:

On 04.06.21 18:11, Greg Kurz wrote:

quoted

fc_mount() already handles the vfs_get_tree(), sb->s_umount
unlocking and vfs_create_mount() sequence. Using it greatly
simplifies fuse_dentry_automount().

Signed-off-by: Greg Kurz <redacted>
---
  fs/fuse/dir.c | 26 +++++---------------------
  1 file changed, 5 insertions(+), 21 deletions(-)

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index b88e5785a3dd..fc9eddf7f9b2 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c

@@ -311,38 +311,22 @@ static struct vfsmount *fuse_dentry_automount(struct path *path)
  	struct fs_context *fsc;
  	struct vfsmount *mnt;
  	struct fuse_inode *mp_fi = get_fuse_inode(d_inode(path->dentry));
-	int err;
  
  	fsc = fs_context_for_submount(path->mnt->mnt_sb->s_type, path->dentry);
-	if (IS_ERR(fsc)) {
-		err = PTR_ERR(fsc);
-		goto out;
-	}
+	if (IS_ERR(fsc))
+		return (struct vfsmount *) fsc;

I think ERR_CAST(fsc) would be nicer.

Indeed. I'll fix that if I need to repost.

Apart from that:

Reviewed-by: Max Reitz <redacted>