Re: [PATCH] fs: don't specify flag FIEMAP_FLAG_SYNC when calling fiemap_prep()
From: Jan Kara <jack@suse.cz>
Date: 2021-02-24 15:10:19
On Tue 23-02-21 21:16:32, Chengguang Xu wrote:
commit 45dd052e67ad17c7a ("fs: handle FIEMAP_FLAG_SYNC in fiemap_prep")
has moved FIEMAP_FLAG_SYNC handling to fiemap_prep(), so don't have
to specify flags FIEMAP_FLAG_SYNC when calling fiemap_prep in
__generic_block_fiemap().
Signed-off-by: Chengguang Xu <redacted>Looks good to me. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza
quoted hunk ↗ jump to hunk
--- fs/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/ioctl.c b/fs/ioctl.c index 4e6cc0a7d69c..49355e689750 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c@@ -303,7 +303,7 @@ static int __generic_block_fiemap(struct inode *inode, bool past_eof = false, whole_file = false; int ret = 0; - ret = fiemap_prep(inode, fieinfo, start, &len, FIEMAP_FLAG_SYNC); + ret = fiemap_prep(inode, fieinfo, start, &len, 0); if (ret) return ret;-- 2.27.0
-- Jan Kara [off-list ref] SUSE Labs, CR