Thread (54 messages) 54 messages, 6 authors, 2021-02-12

Re: [v7 PATCH 01/12] mm: vmscan: use nid from shrink_control for tracepoint

From: Yang Shi <hidden>
Date: 2021-02-10 17:00:06
Also in: linux-mm, lkml 

On Tue, Feb 9, 2021 at 11:14 AM Shakeel Butt [off-list ref] wrote:
On Tue, Feb 9, 2021 at 9:47 AM Yang Shi [off-list ref] wrote:
quoted
The tracepoint's nid should show what node the shrink happens on, the start tracepoint
uses nid from shrinkctl, but the nid might be set to 0 before end tracepoint if the
shrinker is not NUMA aware, so the traceing
tracing
Fixed. Thanks.

quoted
log may show the shrink happens on one
node but end up on the other node.  It seems confusing.  And the following patch
will remove using nid directly in do_shrink_slab(), this patch also helps cleanup
the code.

Acked-by: Vlastimil Babka <redacted>
Acked-by: Kirill Tkhai <redacted>
Signed-off-by: Yang Shi <redacted>
Reviewed-by: Shakeel Butt <redacted>
  



    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help