Re: [PATCH] do_generic_file_read(): Fail immediately if killed
From: Michal Hocko <mhocko@kernel.org>
Date: 2016-08-17 17:20:21
Also in:
linux-mm
On Tue 16-08-16 17:00:43, Bart Van Assche wrote:
If a fatal signal has been received, fail immediately instead of
trying to read more data.
See also commit ebded02788b5 ("mm: filemap: avoid unnecessary
calls to lock_page when waiting for IO to complete during a read")
Signed-off-by: Bart Van Assche <redacted>
Cc: Mel Gorman <redacted>
Cc: Jan Kara <jack@suse.cz>
Cc: Hugh Dickins <hughd@google.com>
Cc: Oleg Nesterov <oleg@redhat.com>If not anything else it makes code more readable because the real error is hidden in page_not_up_to_date: currently... Acked-by: Michal Hocko <mhocko@suse.com>
quoted hunk ↗ jump to hunk
--- mm/filemap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/mm/filemap.c b/mm/filemap.c index 2a9e84f6..bd8ab63 100644 --- a/mm/filemap.c +++ b/mm/filemap.c@@ -1721,7 +1721,9 @@ find_page: * wait_on_page_locked is used to avoid unnecessarily * serialisations and why it's safe. */ - wait_on_page_locked_killable(page); + error = wait_on_page_locked_killable(page); + if (unlikely(error)) + goto readpage_error; if (PageUptodate(page)) goto page_ok;-- 2.9.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
-- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>