Thread (14 messages) 14 messages, 5 authors, 2016-02-26

Re: [PATCH 8/8] net: sunrpc: Replace CURRENT_TIME by current_fs_time()

From: Trond Myklebust <hidden>
Date: 2016-02-22 15:34:32
Also in: linux-nfs, lkml, netdev

On Mon, Feb 22, 2016 at 10:17 AM, Deepa Dinamani [off-list ref] wrote:
quoted hunk ↗ jump to hunk
CURRENT_TIME macro is not appropriate for filesystems as it
doesn't use the right granularity for filesystem timestamps.
Use current_fs_time() instead.

Signed-off-by: Deepa Dinamani <redacted>
Cc: "J. Bruce Fields" <redacted>
Cc: Jeff Layton <redacted>
Cc: Trond Myklebust <redacted>
Cc: Anna Schumaker <redacted>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-nfs@vger.kernel.org
Cc: netdev@vger.kernel.org
---
 net/sunrpc/rpc_pipe.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
index 31789ef..bab3187 100644
--- a/net/sunrpc/rpc_pipe.c
+++ b/net/sunrpc/rpc_pipe.c
@@ -477,7 +477,9 @@ rpc_get_inode(struct super_block *sb, umode_t mode)
                return NULL;
        inode->i_ino = get_next_ino();
        inode->i_mode = mode;
-       inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
+       inode->i_atime = current_fs_time(sb);
+       inode->i_mtime = inode->i_atime;
+       inode->i_ctime = inode->i_atime;
        switch (mode & S_IFMT) {
        case S_IFDIR:
                inode->i_fop = &simple_dir_operations;
Why would we care? This is a pseudo-fs. There is no expectation w.r.t.
timestamp accuracy or resolution.

Cheers,
  Trond
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help