Thread (1 message) 1 message, 1 author, 2012-06-11

Re: [PATCH 00/21] vfs: atomic open v6 (part 2)

From: Miklos Szeredi <miklos@szeredi.hu>
Date: 2012-06-11 16:33:20
Also in: lkml

I don't like this:

    make ->atomic_open() return int
    
    Change of calling conventions:
    old         new
    NULL                1
    file                0
    ERR_PTR(-ve)        -ve
    
    Caller *knows* that struct file *; no need to return it.

Yes, ordinary filesystems the caller knows the 'struct file *' but for
overlayfs (and stacking in general) wants to be able to return a file
obtained by opening the file on another filesystem.

Thanks,
Miklos
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help