Re: [PATCH 69/73] ext2: Add fallthru support [ver #2]
From: Ted Ts'o <tytso@mit.edu>
Date: 2012-02-27 00:33:12
Also in:
linux-ext4, lkml
On Tue, Feb 21, 2012 at 06:06:11PM +0000, David Howells wrote:
From: Valerie Aurora <redacted> Add support for fallthru directory entries to ext2.
As I mentioned, I wonder if it makes sense combine the patches for whiteout and fallthrough director entries into a single patch. Given that the two patches modify the same functions, and in some cases second modifies lines added or modified by first, it just makes life easier if the two are folded together.
quoted hunk ↗ jump to hunk
--- a/include/linux/ext2_fs.h +++ b/include/linux/ext2_fs.h@@ -506,11 +506,14 @@ struct ext2_super_block { #define EXT3_FEATURE_INCOMPAT_JOURNAL_DEV 0x0008 #define EXT2_FEATURE_INCOMPAT_META_BG 0x0010 #define EXT2_FEATURE_INCOMPAT_WHITEOUT 0x0020 +/* ext3/4 incompat flags take up the intervening constants */ +#define EXT2_FEATURE_INCOMPAT_FALLTHRU 0x2000
... and the codepoint 0x2000 in the INCOMPAT mask has since already been assigned. As I mentioned in a comment to the previous patch, any objections if you combine these two fields into a single ROCOMPAT feature? #define EXT2_FEATURE_RO_COMPAT_UNION_MOUNT 0x0800 - Ted