Thread (11 messages) 11 messages, 4 authors, 2012-02-10

Re: [PATCH 1/2] vfs: Provide function to get superblock and wait for it to thaw

From: Dave Chinner <david@fromorbit.com>
Date: 2012-02-10 23:16:33
Also in: lkml

On Fri, Feb 10, 2012 at 10:48:58AM +0100, Jan Kara wrote:
On Thu 09-02-12 10:37:20, Eric Sandeen wrote:
quoted
would "wait_for_thaw" vs. "thaw" be any clearer?  Nitpicky I guess but the
meaning of "thawed" isn't immediately clear here.  If it's already thawed?  If
we want to wait for it it to be thawed?  You can figure it out from the callers
but maybe a comment or a different name might help.  No big deal.
  How about "wait_thaw". That should be explicit enough...
IMO, wait_for_thaw is much easier to read (i.e. better english ;) and
hence the code documents itself better. There's no reason to skimp
on characters here - it's not a heavily used variable....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help