Re: [PATCH 1/2] block: introduce BIO_IN_FLIGHT flag

Hello,

On Mon, Jan 09, 2012 at 11:57:43AM +0900, Namhyung Kim wrote:

I understand your concerns. However, the blktrace cannot get
bio->bi_flags info in its current form AFAIK. Doing it will require
extending struct blk_io_trace and it'll cause a compatibility issue,
I guess.

Umm?  Why can't blk_add_trace_bio_complete() look at the flags (or
whatever other states) to decide to fire off BLK_TA_COMPLETE or not?
What's the difference?  No userland visible change is necessary at
all.  Just make blktrace.c do the right thing.  Am I missing
something?

Thanks.

-- 
tejun