Thread (58 messages) 58 messages, 14 authors, 2009-11-09

Re: [PATCH 12/27] BKL: Remove BKL from btrfs

From: Chris Mason <hidden>
Date: 2009-11-02 12:13:08
Also in: linux-btrfs, lkml

On Mon, Nov 02, 2009 at 11:04:52AM +0100, Jan Blunck wrote:
BKL is only used in get_sb. It is safe to remove it.

Signed-off-by: Jan Blunck <redacted>
Acked-by: Chris Mason <redacted>

Thanks!

-chris
quoted hunk ↗ jump to hunk
---
 fs/btrfs/super.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index e5cd2cf..752a546 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -480,17 +480,13 @@ static int btrfs_get_sb(struct file_system_type *fs_type, int flags,
 	fmode_t mode = FMODE_READ;
 	int error = 0;
 
-	lock_kernel();
-
 	if (!(flags & MS_RDONLY))
 		mode |= FMODE_WRITE;
 
 	error = btrfs_parse_early_options(data, mode, fs_type,
 					  &subvol_name, &fs_devices);
-	if (error) {
-		unlock_kernel();
+	if (error)
 		return error;
-	}
 
 	error = btrfs_scan_one_device(dev_name, mode, fs_type, &fs_devices);
 	if (error)
@@ -559,7 +555,6 @@ static int btrfs_get_sb(struct file_system_type *fs_type, int flags,
 	mnt->mnt_root = root;
 
 	kfree(subvol_name);
-	unlock_kernel();
 	return 0;
 
 error_s:
@@ -568,7 +563,6 @@ error_close_devices:
 	btrfs_close_devices(fs_devices);
 error_free_subvol_name:
 	kfree(subvol_name);
-	unlock_kernel();
 	return error;
 }
 
-- 
1.6.4.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help