Thread (11 messages) 11 messages, 5 authors, 2002-05-01

Re: [PATCH/RFC] Replacing iget4/read_inode2 with icreate

From: Alexander Viro <hidden>
Date: 2002-05-01 03:25:43


On Tue, 30 Apr 2002, Jan Harkes wrote:
On Tue, Apr 30, 2002 at 01:03:46PM -0400, Jan Harkes wrote:
Thought I had already sent the latest version of the patch before I went
home...

This is the 6th iteration of the patch and it pulls everything together
as well as adding a bit to Documentation/filesystems/porting.
Why are you passing ino?  If anything, it can be derived from the
last argument (and set by set())...

I would probably add two helpers - icreate() (as in your variant, but
without ino) and icreate_light() - with ino, but without last 3 arguments.

And then switched callers of iget() to icreate_liget()...

When some filesystem stops using iget() we can drop its ->read_inode().
When all of them are converted we can kill the method itself.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help