Re: [PATCH v8 08/11] fs: introduce SB_INLINECRYPT
From: Eric Biggers <ebiggers@kernel.org>
Date: 2020-03-15 19:05:36
Also in:
linux-block, linux-ext4, linux-f2fs-devel, linux-fsdevel, linux-scsi
On Thu, Mar 12, 2020 at 01:02:50AM -0700, Satya Tangirala wrote:
quoted hunk ↗ jump to hunk
Introduce SB_INLINECRYPT, which is set by filesystems that wish to use blk-crypto for file content en/decryption. Signed-off-by: Satya Tangirala <redacted> --- fs/proc_namespace.c | 1 + include/linux/fs.h | 1 + 2 files changed, 2 insertions(+)diff --git a/fs/proc_namespace.c b/fs/proc_namespace.c index 273ee82d8aa9..8bf195d3bda6 100644 --- a/fs/proc_namespace.c +++ b/fs/proc_namespace.c@@ -49,6 +49,7 @@ static int show_sb_opts(struct seq_file *m, struct super_block *sb) { SB_DIRSYNC, ",dirsync" }, { SB_MANDLOCK, ",mand" }, { SB_LAZYTIME, ",lazytime" }, + { SB_INLINECRYPT, ",inlinecrypt" }, { 0, NULL } }; const struct proc_fs_info *fs_infop;diff --git a/include/linux/fs.h b/include/linux/fs.h index 3cd4fe6b845e..08a0395674dd 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h@@ -1370,6 +1370,7 @@ extern int send_sigurg(struct fown_struct *fown); #define SB_NODIRATIME 2048 /* Do not update directory access times */ #define SB_SILENT 32768 #define SB_POSIXACL (1<<16) /* VFS does not apply the umask */ +#define SB_INLINECRYPT (1<<17) /* inodes in SB use blk-crypto */
"inodes use blk-crypto" isn't very clear. It could be misunderstand as meaning something like "does the filesystem contain any encrypted files". I think the following would be a bit clearer: /* Use blk-crypto for encrypted files */ (And these flags are obviously per-sb, so there's no need to write "in SB".)