Thread (6 messages) 6 messages, 3 authors, 4d ago

Re: [PATCH] staging: fbtft: Remove unused macro

flat view

From: Andy Shevchenko <hidden>
Date: 2026-10-26 09:23:18
Also in: dri-devel, linux-staging, lkml

On Mon, Oct 26, 2026 at 01:48:32PM +0530, himanshu bakshi wrote:
From: Himanshu Bakshi <redacted>

fbtft_init_dbg is not used in drivers/staging/fbtft directory and
We refer to the functions and semantically similar macros as
func() or macro() in the text and comments.
since dev_dbg messages are good enough, fbtft_init_dbg should be
Ditto for both dev_dbg() and fbtft_init_dbg().
removed. After compiling the driver, there are no undefined macro
issues.
Signed-off-by: Himanshu Bakshi <redacted>
---
It doesn't say how you tested this, though.

...

Code wise LGTM.

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help