[PATCH v2] staging: sm750fb: remove unnecessary goto
flat view
WARM2d
From: Haasham Khan <hidden>
Date: 2026-10-25 16:26:57
Also in:
linux-staging, lkml
Subsystem:
staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest · Maintainers:
Sudip Mukherjee, Teddy Wang, Sudip Mukherjee, Greg Kroah-Hartman, Linus Torvalds
Return directly when setting the mode timing fails, rather than jumping to a label that only returns ret. Return 0 on the successful path. Signed-off-by: Haasham Khan <redacted> --- Changes in v2: - Return 0 on the successful path, as suggested by Dan Carpenter. drivers/staging/sm750fb/sm750_hw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index c4358d3e5091..4dfa1cb6b352 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c@@ -272,7 +272,7 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, ret = ddk750_set_mode_timing(&modparm, clock); if (ret) { dev_err(&sm750_dev->pdev->dev, "Set mode timing failed\n"); - goto exit; + return ret; } if (crtc->channel != sm750_secondary) {
@@ -332,8 +332,7 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, poke32(CRT_DISPLAY_CTRL, reg); } -exit: - return ret; + return 0; } int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index, ushort red,
--
2.53.0