Thread (3 messages) 3 messages, 2 authors, 1d ago

Re: [PATCH] staging: fbtft: remove unused argument from FBTFT_SPI_DRIVER()

flat view

From: Aditya Nagar <hidden>
Date: 2026-10-25 06:00:46
Also in: dri-devel, linux-staging, lkml

Hi Greg,

Thanks for the explanation, understood the message and I apologise.

Thanks,
Aditya

On Sun, Oct 25, 2026 at 11:25 AM Greg Kroah-Hartman
[off-list ref] wrote:
On Sun, Oct 25, 2026 at 10:51:36AM +0530, Aditya Nagar wrote:
quoted
The _compatible argument of FBTFT_SPI_DRIVER() is never used in the
macro body. The device tree match table is created separately by
FBTFT_DT_TABLE() in both callers, FBTFT_REGISTER_DRIVER() and
FBTFT_REGISTER_SPI_DRIVER().

Drop the argument and update both callers. No functional change.

The argument has been unused since the macro was introduced in commit
c222ea5d2f33 ("staging: fbtft: Deduplicate driver registration macros").

Found with checkpatch.pl (MACRO_ARG_UNUSED). The change was prepared
with the help of an AI coding assistant (Claude); I reviewed it and
build-tested all fbtft drivers with W=1.

Signed-off-by: Aditya Nagar <redacted>
Sorry, but please read:
        https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh (local)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help