Thread (2 messages) 2 messages, 2 authors, 5d ago

[PATCH] staging: sm750fb: remove unused CRTC cursor fields

flat view
COOLING5d

From: Xia Yan <hidden>
Date: 2026-10-15 08:29:43
Also in: linux-staging, lkml
Subsystem: staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest · Maintainers: Sudip Mukherjee, Teddy Wang, Sudip Mukherjee, Greg Kroah-Hartman, Linus Torvalds

The v_cursor and o_cursor members of struct lynxfb_crtc are never read
or written. The cursor setup and update paths use cursor.vstart and
cursor.offset in the embedded struct lynx_cursor instead.

Remove the unused members to avoid keeping a second, unused set of
cursor location fields. No functional change is intended.

Assisted-by: LLM
Signed-off-by: Xia Yan <redacted>
---

Notes (validation):
    Compile-tested on x86_64 with GCC 12.3.1 and CONFIG_FB_SM750=m, using W=1.
    All driver objects and the combined sm750fb.o built successfully.

 drivers/staging/sm750fb/sm750.h | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index fd1cf9e..6e427d1 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -123,9 +123,7 @@ struct lynx_cursor {
 };
 
 struct lynxfb_crtc {
-	unsigned char __iomem *v_cursor; /* virtual address of cursor */
 	unsigned char __iomem *v_screen; /* virtual address of on_screen */
-	int o_cursor; /* cursor address offset in vidmem */
 	int o_screen; /* onscreen address offset in vidmem */
 	int channel;/* which channel this crtc stands for*/
 	resource_size_t vidmem_size;/* this view's video memory max size */
base-commit: cccafd0f36d8c30d4dcbdce26971dab15e8ab25b
-- 
2.33.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help