Re: [PATCH] staging: sm750fb: make g_fbmode array const

On 10/12/26 9:22 AM, Palak Dixit wrote:

Hi Ahmet,

Thanks for the review.

I enabled CONFIG_FB_SM750 and verified the patch by building the driver with:

     make M=drivers/staging/sm750fb

The build completed successfully and the sm750fb .ko module was generated.

Thanks,
Palak Raval

g_fbmode[] is assigned in lynxfb_set_fbinfo() and sm750fb_setup(), so this can't build. Maybe the .ko was left over from an earlier build? "make drivers/staging/sm750fb/sm750.o" should show the error.

This change has been sent and rejected many times before, see:
https://lore.kernel.org/linux-staging/?q=g_fbmode

Also, it doesn't even apply to Greg's staging-testing branch, make sure to rebase.

Regards,
Ahmet Sezgin Duran