Thread (5 messages) flat view 5 messages, 2 authors, 1d ago

Re: [PATCH 2/2] staging: sm750fb: remove unused definitions from ddk750_reg.h

From: Gabriel Changamire <hidden>
Date: 2026-09-14 17:32:50
Also in: linux-staging, lkml

Thanks for the Acked-by and for the feedback on patch 2. That makes
sense — I’ll drop patch 2 and leave those register definitions in
place.

Regards,
Gabriel

On Mon, 14 Sep 2026 11:54:03 +0300, Dan Carpenter [off-list ref] wrote:
On Sun, Sep 13, 2026 at 04:01:40AM +0000, Gabriel Changamire wrote:
quoted
The sm750fb TODO asks for unused code to be removed. Of the 1203
register and field definitions in ddk750_reg.h, 1046 are referenced
neither by the rest of the driver nor, transitively, by any definition
that is referenced.

Remove them, together with section comments that are left with no
content beneath them. The include guard and all VALIDATION_CHIP
conditional blocks are preserved.

Build-tested: all driver objects are byte-identical before and after
the change. No functional change.

Signed-off-by: Gabriel Changamire <redacted>
---
These macros are just documentation and they don't hurt readability.
They probably improve readability.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help