[PATCH 01/03] fbdev: maxine: make functions static
From: Randy Dunlap <hidden>
Date: 2026-08-13 23:29:53
Also in:
dri-devel, lkml
Make 3 functions static so that they don't need to be declared in a header file. ../drivers/video/fbdev/maxinefb.c:64:6: warning: no previous prototype for 'maxinefb_ims332_write_register' [-Wmissing-prototypes] 64 | void maxinefb_ims332_write_register(int regno, register unsigned int val) ../drivers/video/fbdev/maxinefb.c:74:14: warning: no previous prototype for 'maxinefb_ims332_read_register' [-Wmissing-prototypes] 74 | unsigned int maxinefb_ims332_read_register(int regno) ../drivers/video/fbdev/maxinefb.c:114:12: warning: no previous prototype for 'maxinefb_init' [-Wmissing-prototypes] 114 | int __init maxinefb_init(void) Signed-off-by: Randy Dunlap <redacted> --- Cc: Helge Deller <deller@gmx.de> Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: "Maciej W. Rozycki" <macro@orcam.me.uk> drivers/video/fbdev/maxinefb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-next-20260812.orig/drivers/video/fbdev/maxinefb.c
+++ linux-next-20260812/drivers/video/fbdev/maxinefb.c@@ -61,7 +61,7 @@ static struct fb_fix_screeninfo maxinefb /* Handle the funny Inmos RamDAC/video controller ... */ -void maxinefb_ims332_write_register(int regno, register unsigned int val) +static void maxinefb_ims332_write_register(int regno, register unsigned int val) { register unsigned char *regs = (char *) MAXINEFB_IMS332_ADDRESS; unsigned char *wptr;
@@ -71,7 +71,7 @@ void maxinefb_ims332_write_register(int *((volatile unsigned short *) (wptr)) = val; } -unsigned int maxinefb_ims332_read_register(int regno) +static unsigned int maxinefb_ims332_read_register(int regno) { register unsigned char *regs = (char *) MAXINEFB_IMS332_ADDRESS; unsigned char *rptr;
@@ -111,7 +111,7 @@ static const struct fb_ops maxinefb_ops .fb_setcolreg = maxinefb_setcolreg, }; -int __init maxinefb_init(void) +static int __init maxinefb_init(void) { unsigned long fboff; unsigned long fb_start;