Thread (4 messages) flat view 4 messages, 4 authors, 17d ago

Re: [PATCH] staging: sm750fb: make g_fbmode array pointers const;prevent accidental modification of entries.

From: Dan Carpenter <hidden>
Date: 2026-08-07 13:19:27
Also in: linux-staging, lkml

On Thu, Aug 06, 2026 at 03:43:25AM +0300, Alexandros Xanthakis wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Alexandros Xanthakis <redacted>
---
 drivers/staging/sm750fb/sm750.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 89c811e0806c..8f533f3b1b42 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -21,7 +21,7 @@
 static int g_hwcursor = 1;
 static int g_noaccel __ro_after_init;
 static int g_nomtrr __ro_after_init;
-static const char *g_fbmode[] = {NULL, NULL};
You're working against a wrong tree because this can't compile.

regards,
dan carpenter
+static const char * const g_fbmode[] = {NULL, NULL};
 static const char *g_def_fbmode = "1024x768-32@60";
 static char *g_settings;
 static int g_dualview __ro_after_init;
-- 
2.55.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help