Re: [PATCH v2 1/2] staging: sm750fb: Remove dead VALIDATION_CHIP preprocessor blocks
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2026-07-28 07:14:42
Also in:
linux-staging, lkml
On Sat, Jul 25, 2026 at 02:37:48PM +0530, Mohit Mishra wrote:
quoted hunk ↗ jump to hunk
@@ -1020,9 +994,7 @@ #define CRT_DISPLAY_CTRL_CRTSELECT BIT(25) #define CRT_DISPLAY_CTRL_RGBBIT BIT(24) -#ifndef VALIDATION_CHIP #define CRT_DISPLAY_CTRL_CENTERING BIT(24) -#endif
The indentation makes no sense here now, right?
quoted hunk ↗ jump to hunk
#define CRT_DISPLAY_CTRL_LOCK_TIMING BIT(23) #define CRT_DISPLAY_CTRL_EXPANSION BIT(22) #define CRT_DISPLAY_CTRL_VERTICAL_MODE BIT(21)@@ -1121,22 +1093,17 @@ /* This vertical expansion below start at 0x080240 ~ 0x080264 */ #define CRT_VERTICAL_EXPANSION 0x080240 -#ifndef VALIDATION_CHIP #define CRT_VERTICAL_CENTERING_VALUE_MASK (0xff << 24) -#endif
Same here :( And elsewhere in this patch. Always look at the end result of your change please. thanks, greg k-h