Re: [PATCH v3] staging: sm750fb: remove dead VALIDATION_CHIP conditionals
flat view
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2026-07-28 07:13:36
Also in:
linux-staging, lkml
On Fri, Jul 24, 2026 at 01:12:59PM +0000, Nils Lehnen wrote:
quoted hunk ↗ jump to hunk
@@ -1020,9 +996,7 @@ #define CRT_DISPLAY_CTRL_CRTSELECT BIT(25) #define CRT_DISPLAY_CTRL_RGBBIT BIT(24) -#ifndef VALIDATION_CHIP #define CRT_DISPLAY_CTRL_CENTERING BIT(24) -#endif
But this define isn't used anywhere.
quoted hunk ↗ jump to hunk
#define CRT_DISPLAY_CTRL_LOCK_TIMING BIT(23) #define CRT_DISPLAY_CTRL_EXPANSION BIT(22) #define CRT_DISPLAY_CTRL_VERTICAL_MODE BIT(21)@@ -1121,22 +1095,17 @@ /* This vertical expansion below start at 0x080240 ~ 0x080264 */ #define CRT_VERTICAL_EXPANSION 0x080240 -#ifndef VALIDATION_CHIP #define CRT_VERTICAL_CENTERING_VALUE_MASK (0xff << 24) -#endif
And neither is this. And now the indentation for all of these does not make any sense, right? thanks, greg k-h