[PATCH 7/7] fbdev: sa1100fb: Remove redundant dev_err()
From: Pan Chuang <hidden>
Date: 2026-07-22 07:58:47
Also in:
dri-devel, lkml
Subsystem:
framebuffer layer, the rest · Maintainers:
Helge Deller, Linus Torvalds
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() call.
Signed-off-by: Pan Chuang <redacted>
---
drivers/video/fbdev/sa1100fb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
index 0d362d2bf0e3..fea0172c45b5 100644
--- a/drivers/video/fbdev/sa1100fb.c
+++ b/drivers/video/fbdev/sa1100fb.c@@ -1167,10 +1167,8 @@ static int sa1100fb_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq, sa1100fb_handle_irq, 0, "LCD", fbi); - if (ret) { - dev_err(&pdev->dev, "request_irq failed: %d\n", ret); + if (ret) return ret; - } fbi->shannon_lcden = gpiod_get_optional(&pdev->dev, "shannon-lcden", GPIOD_OUT_LOW);
--
2.34.1