Thread (3 messages) 3 messages, 3 authors, 2d ago

Re: [PATCH] fonts: fixup font.h kernel-doc warnings

From: Thomas Zimmermann <tzimmermann@suse.de>
Date: 2026-07-20 12:54:08
Also in: dri-devel


Am 18.07.26 um 21:13 schrieb Randy Dunlap:
Use the typedef keyword when describing a typedef.
Add the missing function return value for font_glyph_size().

Warning: include/linux/font.h:84 cannot understand function prototype:
   'typedef const unsigned char font_data_t;'
Warning: include/linux/font.h:53 No description found for return value
   of 'font_glyph_size'

Signed-off-by: Randy Dunlap <redacted>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks a lot for the bug fix.
quoted hunk ↗ jump to hunk
---
Cc: Helge Deller <deller@gmx.de>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: linux-fbdev@vger.kernel.org

  include/linux/font.h |    4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
--- linux-next-20260717.orig/include/linux/font.h
+++ linux-next-20260717/include/linux/font.h
@@ -49,6 +49,8 @@ static inline unsigned int font_glyph_pi
   * scanlines, which is usually the glyph's height in scanlines. Fonts
   * coming from user space can sometimes have a different vertical pitch
   * with empty scanlines between two adjacent glyphs.
+ *
+ * Returns: the number of bytes per glyph
   */
  static inline unsigned int font_glyph_size(unsigned int width, unsigned int vpitch)
  {
@@ -60,7 +62,7 @@ static inline unsigned int font_glyph_si
   */
  
  /**
- * font_data_t - Raw font data
+ * typedef font_data_t - Raw font data
   *
   * Values of type font_data_t store a pointer to raw font data. The format
   * is monochrome. Each bit sets a pixel of a stored glyph. Font data does
-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help