Re: [PATCH] staging: sm750fb: select FB_IOMEM_FOPS in Kconfig
From: Ahmet Sezgin Duran <hidden>
Date: 2026-07-20 07:54:53
Also in:
linux-staging, lkml
On 7/19/26 10:58 PM, MishraMohit21 wrote:
quoted hunk ↗ jump to hunk
The driver uses the FB_DEFAULT_IOMEM_OPS macro in sm750.c to define its framebuffer operations. This macro references core framebuffer operations fb_io_read, fb_io_write, and fb_io_mmap. These symbols are defined in fb_io_fops.c, which is compiled only under CONFIG_FB_IOMEM_FOPS. Since config FB_SM750 does not currently select FB_IOMEM_FOPS, compiling the driver on a config that has no other framebuffer drivers enabled fails with undefined symbol link errors during MODPOST. Add 'select FB_IOMEM_FOPS' to Kconfig to ensure the driver core helpers build successfully in all configurations. Keep the select statements sorted alphabetically. Signed-off-by: MishraMohit21 <redacted> --- drivers/staging/sm750fb/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/drivers/staging/sm750fb/Kconfig b/drivers/staging/sm750fb/Kconfig index 08bcccdd0f1c..7d5ad423e41f 100644 --- a/drivers/staging/sm750fb/Kconfig +++ b/drivers/staging/sm750fb/Kconfig@@ -2,10 +2,11 @@ config FB_SM750 tristate "Silicon Motion SM750 framebuffer support" depends on FB && PCI && HAS_IOPORT - select FB_MODE_HELPERS - select FB_CFB_FILLRECT select FB_CFB_COPYAREA + select FB_CFB_FILLRECT select FB_CFB_IMAGEBLIT + select FB_IOMEM_FOPS + select FB_MODE_HELPERS help Frame buffer driver for the Silicon Motion SM750 chip with 2D acceleration and dual head support.
Does not apply to Greg's staging-testing branch. `FB_IOMEM_FOPS` already exists in Kconfig. Also you need to put a fullname in `Signed-off-by` part. Regards, Ahmet Sezgin Duran