Thread (2 messages) flat view 2 messages, 2 authors, 2026-07-18

Re: [PATCH] fbdev: sstfb: add missing MODULE_DEVICE_TABLE()

From: Helge Deller <deller@gmx.de>
Date: 2026-07-18 18:55:43
Also in: dri-devel, lkml

On 7/5/26 02:14, Pengpeng Hou wrote:
quoted hunk ↗ jump to hunk
The driver has a match table for the pci bus wired into its driver
structure, but the table is not exported with MODULE_DEVICE_TABLE().

Add the missing MODULE_DEVICE_TABLE() entry so module alias information
is generated for automatic module loading.

This is a source-level fix.  It does not claim dynamic hardware
reproduction; the evidence is the driver-owned match table, its use by
the driver registration structure, and the missing module alias
publication.

Signed-off-by: Pengpeng Hou <redacted>
---
  drivers/video/fbdev/sstfb.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/sstfb.c b/drivers/video/fbdev/sstfb.c
index 2ea947f57efb..2745557822f7 100644
--- a/drivers/video/fbdev/sstfb.c
+++ b/drivers/video/fbdev/sstfb.c
@@ -1492,6 +1492,7 @@ static const struct pci_device_id sstfb_id_tbl[] = {
  		.driver_data = ID_VOODOO2, },
  	{ 0 },
  };
+MODULE_DEVICE_TABLE(pci, sstfb_id_tbl);
I'm not sure if it was intentionally not added, maybe because it's an
add-on card for which people should manually load the driver.

Anyway, I'm adding this patch now to the fbdev git tree and will find out if
someone reports a regression...

Thanks!
Helge
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help