Thread (6 messages) 6 messages, 2 authors, 2d ago

Re: [PATCH 2/2] staging: sm750fb: unindent defines left by conditional removal

From: Nils Lehnen <hidden>
Date: 2026-07-18 06:31:46
Also in: linux-staging, lkml

On Sat, Jul 18, 2026 at 08:20:36AM +0200, Greg Kroah-Hartman wrote:
No, this is not correct, the indentation gives you context of what is
happening.
Right, the indented defines are the values of the field define right
above them, and unindenting throws that context away. I'll drop this
patch.

A v2 of the series crossed with your review -- please disregard its
patch 2/2 as well. A v3 with only the conditional removal follows.

Sorry also for the subject-less 1/2 in this thread; that was a local
send-email mishap on my side.

Thanks for the review,

Nils
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help