Thread (4 messages) 4 messages, 2 authors, 11h ago
HOTtoday
Revisions (2)
  1. v1 [diff vs current]
  2. v2 current

[PATCH v2 0/2] staging: sm750fb: remove dead VALIDATION_CHIP code

From: Nils Lehnen <hidden>
Date: 2026-07-18 06:21:03
Also in: linux-staging, lkml

VALIDATION_CHIP is defined nowhere in the tree, yet fourteen
preprocessor conditionals in the sm750fb DDK files still test it.
Patch 1 resolves all of them (dead branches dropped, always-true
branches kept), as the driver TODO asks under "remove unused code";
patch 2 cleans up the indentation and blank lines the removal leaves
behind.

Verification, both patches: the disassembly of all ten sm750fb object
files (objdump -d, x86, CONFIG_FB_SM750=m) is bit-identical across the
series. Compile-tested only; no SM750 hardware available.

All English text in this series (cover letter, commit messages, code
comments) was translated from a German draft with the assistance of
Claude Fable 5.

v2: resend of v1 -- patch 1/2 of v1 arrived with an empty subject due
to a local send mishap; no code changes.
v1: https://lore.kernel.org/r/20260718055132.441-1-nils.lehnen@proton.me (local)

Nils Lehnen (2):
  staging: sm750fb: remove dead VALIDATION_CHIP conditionals
  staging: sm750fb: unindent defines left by conditional removal

 drivers/staging/sm750fb/ddk750_reg.h   | 84 ++++++++------------------
 drivers/staging/sm750fb/ddk750_chip.c  |  4 --
 drivers/staging/sm750fb/ddk750_power.c |  6 --
 3 files changed, 24 insertions(+), 70 deletions(-)


base-commit: 64276d9bfe4d1fdd5cf2636f1065f7ea55c2defb
-- 
2.43.0

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help