Re: [PATCH 16/16] arm: omap2: remove remaining pdata-quirks for pandora legacy devices
From: Andreas Kemnade <andreas@kemnade.info>
Date: 2026-07-15 08:00:40
Also in:
dri-devel, linux-arm-kernel, linux-devicetree, linux-omap, linux-sound, lkml
On Sat, 11 Jul 2026 08:02:03 +0200 "H. Nikolaus Schaller" [off-list ref] wrote:
After updating the pandora-backligt setup and removing the omap3pandora sound system and defining related gpios by device tree, we can remove omap3_pandora_legacy_init() and the related legacy devices completely. Signed-off-by: H. Nikolaus Schaller <redacted>
regarding bisectabily: Do we create mess, if the platform devices via quirks are disabled? I am wondering how we handle this. If this patch goes together with the removal of the legacy drivers, then there might be a situation where neither the new one nor the old one is available? Split this all up? If sound discussion takes longer, maybe do the backlight thing alone? Regards, Andreas
quoted hunk ↗ jump to hunk
--- arch/arm/mach-omap2/pdata-quirks.c | 23 ----------------------- 1 file changed, 23 deletions(-)diff --git a/arch/arm/mach-omap2/pdata-quirks.cb/arch/arm/mach-omap2/pdata-quirks.c index b947bacf23a37..aca7097a692ed 100644 --- a/arch/arm/mach-omap2/pdata-quirks.c +++ b/arch/arm/mach-omap2/pdata-quirks.c @@ -268,27 +268,6 @@ static void __init omap3_logicpd_torpedo_init(void) omap3_gpio126_127_129(); } -/* omap3pandora legacy devices */ - -static struct platform_device pandora_backlight = { - .name = "pandora-backlight", - .id = -1, -}; - -static struct gpiod_lookup_table pandora_soc_audio_gpios = { - .dev_id = "soc-audio", - .table = { - GPIO_LOOKUP("gpio-112-127", 6, "dac", GPIO_ACTIVE_HIGH), - GPIO_LOOKUP("gpio-0-15", 14, "amp", GPIO_ACTIVE_HIGH), - { } - }, -}; - -static void __init omap3_pandora_legacy_init(void) -{ - platform_device_register(&pandora_backlight); - gpiod_add_lookup_table(&pandora_soc_audio_gpios); -} #endif /* CONFIG_ARCH_OMAP3 */ #ifdef CONFIG_SOC_DRA7XX@@ -514,8 +493,6 @@ static struct pdata_init pdata_quirks[]__initdata = { { "ti,omap3-evm-37xx", omap3_evm_legacy_init, }, { "ti,am3517-evm", am3517_evm_legacy_init, }, { "technexion,omap3-tao3530", omap3_tao3530_legacy_init, }, - { "openpandora,omap3-pandora-600mhz", omap3_pandora_legacy_init, }, - { "openpandora,omap3-pandora-1ghz", omap3_pandora_legacy_init, }, #endif { /* sentinel */ }, };