On 6/23/26 00:57, Helge Deller wrote:

On 6/16/26 06:30, Chintan Patel wrote:

quoted

Claim the memory resource associated with the Cyber2000 SPARC MMIO
aperture before accessing it.

This is part of the effort to request memory regions in fbdev drivers.

IMHO this patch doesn't make much sense.
The PCI regions (e.g. for x86) are already requested one level higher 
and are being kept reserved.
This patch here only touches the SPARC code inside a path which is e.g. 
being used everytime the machine wakes up from sleep (does sparc even 
suspends?). So, instead here, I think (if you want to make this robust) 
the region should be reserved e.g. in cyberpro_common_probe(), but I'm 
not sure if this is even worth the effort....?

Helge

Hi Helge,

Thanks for the explanation.

That makes sense. I was following the fbdev TODO item to request memory
regions, but I agree that reserving and releasing the region in
cyberpro_pci_enable_mmio() isn't the right lifetime if the function can
be called multiple times.

I'll take a closer look at whether the reservation belongs in
cyberpro_common_probe(). If not, I'll drop this patch.

Thanks,
Chintan