Thread (3 messages) 3 messages, 3 authors, 3d ago

Re: [PATCH] staging: sm750fb: make g_fbmode array const pointer const

From: Ahmet Sezgin Duran <hidden>
Date: 2026-06-25 07:33:55
Also in: linux-staging, lkml

On 6/25/26 2:39 AM, Shravya wrote:
quoted hunk ↗ jump to hunk
Add the const qualifier to the g_fbmode array pointers to make
the entire structure read-only. This resolves a checkpatch warning
and allows the compiler to put the data into the read-only segment.

Signed-off-by: Shravya <redacted>
---
  drivers/staging/sm750fb/sm750.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 89c811e0806c..8f533f3b1b42 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -21,7 +21,7 @@
  static int g_hwcursor = 1;
  static int g_noaccel __ro_after_init;
  static int g_nomtrr __ro_after_init;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
  static const char *g_def_fbmode = "1024x768-32@60";
  static char *g_settings;
  static int g_dualview __ro_after_init;
Did you compile this patch while sm750fb module is enabled?

Regards,
Ahmet Sezgin Duran
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help