Re: [PATCH 4/4] drm/draw: Remove unused helper drm_draw_get_char_bitmap()
From: Jocelyn Falempe <jfalempe@redhat.com>
Date: 2026-06-01 11:20:05
Also in:
dri-devel
On 29/05/2026 16:01, Thomas Zimmermann wrote:
Glyph-shape lookup has been integrated into the font-data interface and all callers have been updated. Remove the old helper.
Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
quoted hunk ↗ jump to hunk
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/drm_draw_internal.h | 7 ------- 1 file changed, 7 deletions(-)diff --git a/drivers/gpu/drm/drm_draw_internal.h b/drivers/gpu/drm/drm_draw_internal.h index 261967145635..44ddcee4744c 100644 --- a/drivers/gpu/drm/drm_draw_internal.h +++ b/drivers/gpu/drm/drm_draw_internal.h@@ -7,7 +7,6 @@ #ifndef __DRM_DRAW_INTERNAL_H__ #define __DRM_DRAW_INTERNAL_H__ -#include <linux/font.h> #include <linux/types.h> struct iosys_map;@@ -18,12 +17,6 @@ static inline bool drm_draw_is_pixel_fg(const u8 *sbuf8, unsigned int spitch, in return (sbuf8[(y * spitch) + x / 8] & (0x80 >> (x % 8))) != 0; } -static inline const u8 *drm_draw_get_char_bitmap(const struct font_desc *font, - char c, size_t font_pitch) -{ - return font->data + (c * font->height) * font_pitch; -} - bool drm_draw_can_convert_from_xrgb8888(u32 format); u32 drm_draw_color_from_xrgb8888(u32 color, u32 format);